ruby icon indicating copy to clipboard operation
ruby copied to clipboard

Update Rubocop to match project philisophy.

Open Insti opened this issue 9 years ago • 9 comments

Following on from the discussion on an exercism.io PR: https://github.com/exercism/exercism.io/pull/3114

The current xruby Rubocop configuration is too strict. Which Rubocop options are important here?

Insti avatar Oct 04 '16 13:10 Insti

Investigating..

kotp avatar Oct 04 '16 20:10 kotp

It boils down to currently just these offenses, I think.

17 Style/FormatString 16 Metrics/MethodLength 6 Metrics/LineLength 3 Style/TrailingCommaInArguments 2 Style/SpaceAroundEqualsInParameterDefault 1 Style/RaiseArgs

This does not state which way the style should be, such as the trailing commas, nor the limit for Line Length, or Method Length, just that they are the ones coming up.

Understand that in my interpretation I am ignoring the example.rb files, which are, as of yet, still "Proof of concept" and not meant to be exemplar programming examples...

kotp avatar Oct 04 '16 22:10 kotp

Space around equals in parameter default, line length, and method length, those are the only ones listed I really have more than passing opinions on, for varying reasons.

kotp avatar Oct 04 '16 22:10 kotp

After doing some thinking of how to get the rules out there, so that they can be discussed, I realized that I can list and disable all of them. See the PR #449 referenced above...

kotp avatar Oct 10 '16 06:10 kotp

It doesn't necessarily complete this issue, as this is a long and ongoing issue, I suspect. But... merged in the "no-op" version of the rubocops.

kotp avatar Oct 11 '16 05:10 kotp

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 29 '17 20:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 30 '17 09:06 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 29 '17 19:08 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 31 '17 10:10 stale[bot]