Insufficient test cases for "Resistor Color Expert"

[xanni]

I submitted code that passed all the existing tests but failed to correctly handle some actual resistor values in use in the E48 (2% tolerance) and larger series. There are currently no tests for 5-band resistors where the second band is black, which my earlier iteration handled wrongly.

[github-actions[bot]]

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

[BethanyG]

Linking forum discussion.

Happy to accept suggested test cases and/or PR. 😄

[xanni]

PR created: https://github.com/exercism/python/pull/3797

[BethanyG]

I am going to keep this open until we figure out if we want 3-band cases. I am leaning towards "no", but want to discuss it a bit on the forum first. 😄

[deekshahavaragi]

I’ve opened a PR with the additional edge-case tests discussed here:

PR: https://github.com/exercism/python/pull/4047

Please let me know if this approach looks good or if any changes are needed. Thanks!

[BethanyG]

Hi @deekshahavaragi -- while I appreciate the enthusiasm, the forum discussion related to this came down on the side of no additional edge cases, since they were wandering away from the intent of the exercise. I forgot to close this issue, but will be doing so now.

Additionally, your PR appears to only have made whitespace changes - was that intentional?