obs-source-record icon indicating copy to clipboard operation
obs-source-record copied to clipboard

It makes OBS crash almost each time I exit OBS

Open tormyvancool opened this issue 1 year ago • 16 comments

Win 11 24H2 Pro OBS 31.0.0

as for the title: it makes OBS crash almost each time I exit OBS

here the topic with the log

https://obsproject.com/forum/threads/each-time-i-close-obs-it-crashes-31-0-0.182958/#post-668567

tormyvancool avatar Dec 30 '24 12:12 tormyvancool

What settings do you use for source record? What steps to reproduce the issue?

exeldro avatar Dec 30 '24 14:12 exeldro

What settings do you use for source record? What steps to reproduce the issue?

Even without using it. Just having it installed.

tormyvancool avatar Dec 30 '24 14:12 tormyvancool

That crash is not possible without having a source record filter on a source. Can you provide an OBS log file? that will allow to tell on what source the source record filter is.

exeldro avatar Dec 30 '24 14:12 exeldro

so far in this scene collections I have not employed it. It is employed in another scene collection that I'm not currently use

Please here the current LOG : https://obsproject.com/logs/Y6eAMuoYOoY0RQyT

tormyvancool avatar Dec 30 '24 14:12 tormyvancool

there is source record filter on multiple sources:

  • 'SCREEN 3' (monitor_capture)
  • 'SCREEN 3 Sub' (monitor_capture)
  • 'LEFT CAM' (dshow_input)
  • 'RIGHT CAM' (dshow_input)

exeldro avatar Dec 30 '24 14:12 exeldro

Probably I forgo it there when I tested it the very first time. HOwever this doesn't change the fact OBS is crashing due it. It shouldn't.

tormyvancool avatar Dec 30 '24 15:12 tormyvancool

Please provide the settings of all of those to find out if they maybe give a clue why it is crashing for you. The things I tested are all working fine, so it must be something different than what I am testing. Without knowing what is causing the issue I can not fix it.

exeldro avatar Dec 30 '24 15:12 exeldro

I changed the scene collection to the one your plugin is employed: https://obsproject.com/logs/tEzO3rKrPqQB68jO

this is the log

tormyvancool avatar Dec 30 '24 15:12 tormyvancool

Please provide the settings of all of those to find out if they maybe give a clue why it is crashing for you. The things I tested are all working fine, so it must be something different than what I am testing. Without knowing what is causing the issue I can not fix it.

as you can see there is nothing special as settings. Just by having your .DLL in use, the crash is guaranteed. I don't understand the reasons. But I can't give more than what I gave since it's nothing special.

The issue is there and I know I'm not the only one. So I hope you can solve this.

tormyvancool avatar Dec 30 '24 21:12 tormyvancool

I don't see the settings used in source record. The OBS log file does not provide information about what settings you used for source record. Please provide the settings used in the source record filter. This can be screenshot or text.

exeldro avatar Dec 31 '24 07:12 exeldro

I don't see the settings used in source record. The OBS log file does not provide information about what settings you used for source record. Please provide the settings used in the source record filter. This can be screenshot or text.

but there is nothing to see. No matter the settings this plugin is making OBS crash when I want to close it.

Here what I have as """"settings"""" nothing so special. ANd these are from the scene collection I posted.

SOURCE GUEST image

SOURCE HOST image

tormyvancool avatar Dec 31 '24 08:12 tormyvancool

I have a similar issue. Not every single time OBS closes, but extremely often. Here's the log I uploaded a little bit ago when trying to diagnose something else: https://obsproject.com/logs/MKcqbhJjb62c7pFZ

EDIT: Here's another log I just made just now and it crashed. https://obsproject.com/logs/eWnjfjxe2mYo7MUZ Though when it did crash when I closed it, it didn't pop up the alert box warning me of it...I only knew it crashed when I opened OBS up again and I got the warning that it didn't shut down properly last time.

I have source-record set for two sources, my webcam and my gameplay. Here's the filters for my game:

Image

Image

Here's the filters for my camera:

Image

Image

Another curious thing, if I hide my webcam source (the eye icon) or the filter itself for source-record within the webcam properties, my camera's blue lights will still be on indicating it's broadcasting something. If I completely delete the filter, then the blue light turns off if I click the eye to hide the camera (aka normal behavior). Not sure if that has anything to do with it, but yea. The mere existence of the filter being on something makes it want to continuously capture something regardless of whether it's active or not.

Hezkezl avatar Apr 10 '25 04:04 Hezkezl

It looks like source record might be trying to record a source with width or height 0. I added some extra checks for that, can you check if this test build fixes it for you? https://github.com/exeldro/obs-source-record/actions/runs/14373613184

exeldro avatar Apr 10 '25 06:04 exeldro

It looks like source record might be trying to record a source with width or height 0. I added some extra checks for that, can you check if this test build fixes it for you? https://github.com/exeldro/obs-source-record/actions/runs/14373613184

Tested it a few times and it seems like it works! I'll give it a bigger test tomorrow, the next time I'm on and streaming.

I did find that OBS will crash if I change the resolution of the game while it's recording, should I file that as a new issue or would that just be a side effect that can't be fixed? (By that I mean it might be obvious that people shouldn't change the size while something is recording because of course it's going to have a brainfart and shut down)

Hezkezl avatar Apr 10 '25 18:04 Hezkezl

resize of source (not scene item) while recording or streaming crashing source record is a separate issue

exeldro avatar Apr 10 '25 18:04 exeldro

Got it, thanks! (sorry for the newbie question, I'm not used to filing issues)

Hezkezl avatar Apr 10 '25 18:04 Hezkezl