obs-source-dock OBS crash on exit bug since 0.3.0, still in latest version.

I and some others have been having crashes on closing of OBS with this plugin installed. This bug has been present since 0.3.0 as far as I can tell and still is in the present version, 0.3.3 (OBS 28 Update). I attached my crash log and I hope that this issue can be fixed in the next release as I'd love to use this in my workflow. :)

BTW I'm intending to criticize your work in anyway in fact I really like the plugins you've made. I just thought I'd let you know about this bug that I've encountered and to make your work even better. :)

crash-2022-09-07-01-47-56.txt

Sep 19 '22 22:09 datlaunchystark

Same problem here. my crash report: obs-studio#7590 No solution yet.

Oct 12 '22 12:10 ifrvn

I confirm that on OBS Studio v.28.1.2 and 29.0, the plugin v.0.3.3 and 0.3.4 either causes the OBS crash on exit with the creation of a crash log in %User_Profile%\AppData\Roaming\obs-studio\crashes, or the crash log is not created, but the application log shows that it does not exit correctly. If crash log is not created when I close OBS Studio in %User_Profile%\AppData\Local\CrashDumps is created dump file with name obs64.exe.####(#).dmp. If I open dump file in WinDbg I see approximately this kind of text:

Microsoft (R) Windows Debugger Version 10.0.25200.1003 AMD64 Copyright (c) Microsoft Corporation. All rights reserved.

Loading Dump File [%USER_PROFILE%\CrashDumps\obs64.exe.10204.dmp] User Mini Dump File: Only registers, stack and portions of memory are available

************* Path validation summary ************** Response Time (ms) Location Deferred srv* Symbol search path is: srv* Executable search path is: Windows 10 Version 19045 MP (4 procs) Free x64 Product: WinNt, suite: SingleUserTS Edition build lab: 19041.1.amd64fre.vb_release.191206-1406 Machine Name: Debug session time: Thu Jan 12 12:33:22.000 2023 (UTC + 3:00) System Uptime: not available Process Uptime: 0 days 0:03:24.000 ................................................................ ................................................................ ................................................................ ................................................................ ................................................................ . Loading unloaded module list .......................... This dump file has an exception of interest stored in it. The stored exception information can be accessed via .ecxr. (27dc.2598): Access violation - code c0000005 (first/second chance not available) For analysis of this file, run !analyze -v ntdll!NtWaitForMultipleObjects+0x14: 00007ff9`b80edc14 c3 ret 0:003> !analyze -v
                                                                        *
                   Exception Analysis                                   *
                                                                        *
KEY_VALUES_STRING: 1
Key  : AV.Fault
Value: Read

Key  : Analysis.CPU.mSec
Value: 843

Key  : Analysis.DebugAnalysisManager
Value: Create

Key  : Analysis.Elapsed.mSec
Value: 3295

Key  : Analysis.IO.Other.Mb
Value: 0

Key  : Analysis.IO.Read.Mb
Value: 0

Key  : Analysis.IO.Write.Mb
Value: 0

Key  : Analysis.Init.CPU.mSec
Value: 359

Key  : Analysis.Init.Elapsed.mSec
Value: 4277

Key  : Analysis.Memory.CommitPeak.Mb
Value: 123

Key  : Timeline.Process.Start.DeltaSec
Value: 204

Key  : WER.OS.Branch
Value: vb_release

Key  : WER.OS.Timestamp
Value: 2019-12-06T14:06:00Z

Key  : WER.OS.Version
Value: 10.0.19041.1

Key  : WER.Process.Version
Value: 29.0.0.0
FILE_IN_CAB: obs64.exe.10204.dmp

NTGLOBALFLAG: 0

PROCESS_BAM_CURRENT_THROTTLED: 0

PROCESS_BAM_PREVIOUS_THROTTLED: 0

APPLICATION_VERIFIER_FLAGS: 0

CONTEXT: (.ecxr) rax=0000000000000000 rbx=0000025a1b035870 rcx=0000025a7bab0000 rdx=000000000000000f rsi=0000000000000400 rdi=0000025a1cb1e270 rip=00007ff961a11ec9 rsp=0000009f33fff870 rbp=0000025a55d17b20 r8=0000025a7bbb4c80 r9=0000000000000001 r10=0000000000008000 r11=0000009f33fff7a0 r12=0000025a7e552328 r13=0000000000000000 r14=0000000000000008 r15=0000000000000000 iopl=0 nv up ei pl nz na pe nc cs=0033 ss=002b ds=002b es=002b fs=0053 gs=002b efl=00010202 obs_text+0x1ec9: 00007ff961a11ec9 488b0f mov rcx,qword ptr [rdi] ds:0000025a1cb1e270=???????????????? Resetting default scope

EXCEPTION_RECORD: (.exr -1) ExceptionAddress: 00007ff961a11ec9 (obs_text+0x0000000000001ec9) ExceptionCode: c0000005 (Access violation) ExceptionFlags: 00000000 NumberParameters: 2 Parameter[0]: 0000000000000000 Parameter[1]: 0000025a1cb1e270 Attempt to read from address 0000025a1cb1e270

PROCESS_NAME: obs64.exe

READ_ADDRESS: 0000025a1cb1e270

ERROR_CODE: (NTSTATUS) 0xc0000005 - 0x%p 0x%p. %s.

EXCEPTION_CODE_STR: c0000005

EXCEPTION_PARAMETER1: 0000000000000000

EXCEPTION_PARAMETER2: 0000025a1cb1e270

STACK_TEXT:
0000009f33fff870 00007ff9a2c3fafc : 00007ff9a2c3fa30 00007ff9a2c8fbf8 0000009f33fff8c8 0000025a55a2c1c0 : obs_text+0x1ec9 0000009f33fff8a0 00007ff9a2c7e78e : 0000025a7bb39fe0 0000025a7bb39fe0 0000025a55d17b20 0000000000000400 : obs!obs_source_default_render+0x36c 0000009f33fff9a0 00007ff9864078b6 : 0000009f33fffa49 0000000000000000 0000000000000000 0000000000000000 : obs!os_task_queue_wait+0x52e 0000009f33fffa00 00007ff9b58f1bb2 : 0000025a7e57f970 0000000000000000 0000000000000000 0000000000000000 : w32_pthreads!ptw32_push_cleanup+0x966 0000009f33fffab0 00007ff9b6207614 : 0000000000000000 0000000000000000 0000000000000000 0000000000000000 : ucrtbase!thread_start<unsigned int (__cdecl*)(void *),1>+0x42 0000009f33fffae0 00007ff9b80a26a1 : 0000000000000000 0000000000000000 0000000000000000 0000000000000000 : kernel32!BaseThreadInitThunk+0x14 0000009f33fffb10 0000000000000000 : 0000000000000000 0000000000000000 0000000000000000 0000000000000000 : ntdll!RtlUserThreadStart+0x21

STACK_COMMAND: ~3s; .ecxr ; kb

SYMBOL_NAME: obs_text+1ec9

MODULE_NAME: obs_text

IMAGE_NAME: obs-text.dll

FAILURE_BUCKET_ID: INVALID_POINTER_READ_c0000005_obs-text.dll!Unknown

OS_VERSION: 10.0.19041.1

BUILDLAB_STR: vb_release

OSPLATFORM_TYPE: x64

OSNAME: Windows 10

IMAGE_VERSION: 29.0.0.0

FAILURE_ID_HASH: {f877a6d0-6afd-da01-fc72-13a581061688}

Followup: MachineOwner

Dump files examples: https://1drv.ms/u/s!Am9vuEBrD-qEgokBAAI2odQpypCPMA?e=hrpN3r

On OBS Studio v.27.2.4 plugin v.0.3.3 and 0.3.4 doesn't cause OBS crash on exit.

OBS28+_2023-01-12 12-30-00.txt OBS28+_2023-01-12 11-38-41.txt OBS28+_2023-01-12 11-35-21.txt OBS28+_2023-01-12 11-25-17.txt OBS28+_Crash 2023-01-12 11-34-38.txt OBS27.2.4_2023-01-12 13-18-36.txt

Jan 12 '23 10:01 Seamas73