fix: specify release bound for compat test
I didn't bisect to find when 3.10 adds the slots argument; I know it's in the release itself, and I don't think we need to be that careful to provide features to old alpha/beta/rc releases.
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:
Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
e717248) 96.07% compared to head (7262cbe) 96.07%.
Additional details and impacted files
@@ Coverage Diff @@
## master #258 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 62 62
Lines 3236 3236
=======================================
Hits 3109 3109
Misses 127 127
| Flag | Coverage Δ | |
|---|---|---|
| pytests | 96.07% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| markdown_it/_compat.py | 87.50% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @agoose77, @hukkin wrote this particular part of the code, and so I would suggest he should have a say on this change before merging
perhaps not worth it to further complicate the tuple comparison
I agree with the principle, but in this case I feel that the extra code is not that much more complex to justify not making this change? I'll defer to your final judgement though — merge this if you're happy, close if not! :)