github-activity icon indicating copy to clipboard operation
github-activity copied to clipboard

Pull requests that happen on the same date as a release are always included even if they happened outside the window of the release

Open consideRatio opened this issue 3 years ago • 0 comments

I ended up observing a PR included in the changelog, even though it was part of the previous tagged release. To reproduce this, one can do...

github-activity --since v3.0.5 --target jupyterhub/action-k3s-helm

I would expect that PR 73 should not have been written out to the changelog.

*   76875ff - Merge pull request #74 from manics/release.md (3 months ago) <Erik Sundell>
|\  
| * c657404 - Add RELEASE.md (3 months ago) <Simon Li>
|/  
*   d3c165a - (tag: v3.0.5) Merge pull request #73 from manics/calico-3.24 (3 months ago) <Simon Li>
|\  
| * e74b367 - Changelog for v3.0.5 - 2022-08-21 (3 months ago) <Simon Li>
| * 9b2415e - Update component versions in README (3 months ago) <Simon Li>
| * 903f39c - Calico 3.24.0 (3 months ago) <Simon Li>
|/  
# v3.0.5...master@{2022-11-14}

([full changelog](https://github.com/jupyterhub/action-k3s-helm/compare/v3.0.5...1039e0fe18752d4aa4a2f8594382d343c1f9728e))

## Bugs fixed

- Calico 3.24.0 (3.23 manifest URL is broken) [#73](https://github.com/jupyterhub/action-k3s-helm/pull/73) ([@manics](https://github.com/manics))

...

A motivation to think of this as a bug is that the comparison we link to, will not include the changes part of the commit that was most recently tagged.

consideRatio avatar Nov 14 '22 13:11 consideRatio