executablebooks
Merging/reviewing a PR as contribution
Following on from #13 and https://github.com/choldgraf/github-activity#how-does-this-tool-define-contributions-in-the-reports
Did we already discuss why someone who merges a PR isn't listed as a contributor? Is that covered because they comment on a PR (PRs == issues?)
It seems unlikely that somehow who can/does merge PRs wouldn't also full fill the other criteria so the net result of this would be zero. However listing the "rules" for how to qualify as contributor will incentivise people to take those actions (all metrics will get gamed, etc). In those case it would be a good thing because people will start doing the stuff that helps move the project forward. Which made me think: getting PRs reviewed/merged is one of the biggest bottlenecks ... can we get people to help here by explicitly listing it as a to contribute?
I just realized I totally missed this issue! I think this is something we should definitely add into the definition of contributor. I'd assume this is an N=1 kinda thing actually, basically "anybody that ever pushed the green button is a contributor."
I'll mark this as an enhancement since I don't think it's currently in our definition criteria
