MyST-NB icon indicating copy to clipboard operation
MyST-NB copied to clipboard

👌 IMPROVE: [code load] Enable utf-8 as the standard encoding for reading code from files

Open mmcky opened this issue 4 years ago • 2 comments

It looks like windows platform doesn't by default always use utf-8 when reading text from files. I think this is a sensible cross-platform default.

https://github.com/QuantEcon/lecture-python.myst/issues/144

There is also a related issue reported on stackoverflow

mmcky avatar Jun 01 '21 05:06 mmcky

Codecov Report

Merging #332 (c234bae) into master (e39132e) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files          12       12           
  Lines        1337     1337           
=======================================
  Hits         1169     1169           
  Misses        168      168           
Flag Coverage Δ
pytests 87.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_nb/converter.py 78.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e39132e...c234bae. Read the comment docs.

codecov[bot] avatar Jun 01 '21 05:06 codecov[bot]