Exceptionless.JavaScript icon indicating copy to clipboard operation
Exceptionless.JavaScript copied to clipboard

Transpile stacktracejs into local esm package and consume it.

Open niemyjski opened this issue 4 years ago • 1 comments

This should resolve all CJS import issues,

I think what was happening is that by default we were saying the main script was index.js (https://github.com/exceptionless/Exceptionless.JavaScript/blob/master/packages/browser/package.json#L27) and that all consumers should use this and tree shake. The problem with this is that we had a dependency on stacktrace-js and import for stacktrace-js so it would always be loaded as a cjs umd module. If you used the bundled version transpiled with esbuild it would have worked.

This pr has a prebuild action to convert the stacktrace-js dependency and it's dependencies to esm local file, the build then references this file instead of the cjs requires and then post build copies this transpiled file to the dist folder (tsc doesn't copy js files or any non ts file by default).

niemyjski avatar Oct 21 '21 13:10 niemyjski

Interesting. Hope it works.

ejsmith avatar Oct 21 '21 13:10 ejsmith

I still need to come up with a solution for: https://github.com/stacktracejs/stacktrace.js/issues/230

niemyjski avatar Feb 14 '23 13:02 niemyjski