Fix squashing of pear exit codes

Open Prill opened this issue 11 years ago • 3 comments

Commit 286125b fixed an error from where badly encoded data would cause crashes, but the fix of piping it through iconv mean that the status code returned was that of iconv. This causes the module to always treat the pear module as "installed," meaning the install exec would never run. This changes fixes that by sending the standard output to /dev/null, which preserves the original exit code.

Nov 04 '14 23:11 Prill

herp, looks like I need to update the test

Nov 05 '14 00:11 Prill

The spec program fails to load module puppet/face on the Puppet 2.6.0 build. As far as I can tell that module only works with 2.7.0 or newer, and it looks like this is also failing on master.

Nov 05 '14 00:11 Prill

For me is ok, maybe @feychenie maybe give his opinion

Nov 05 '14 10:11 alvagante