Please add "OracleLinux" to your modules

[supernovae]

The version checking in some of your puppet-modules-nextgen checks for redhat, centos and scientific Linux, but doesn't look for "OracleLinux". Can you add "OracleLinux" to the default checks? :+1:

I think debian has a bug with facter so everyone has to fugde around it, but the MySQL puppet code I found here seems to have the most platform support:

Use "osfamily" if available (which should be RedHat for all RedHat OS's), otherwise, derive the crap and re-create it :)

Thanks!

if ! $::osfamily { case $::operatingsystem { 'RedHat', 'Fedora', 'CentOS', 'Scientific', 'SLC', 'Ascendos', 'CloudLinux', 'PSBM', 'OracleLinux', 'OVS', 'OEL': { $osfamily = 'RedHat' } 'ubuntu', 'debian': { $osfamily = 'Debian' } 'SLES', 'SLED', 'OpenSuSE', 'SuSE': { $osfamily = 'Suse' } 'Solaris', 'Nexenta': { $osfamily = 'Solaris' } default: { $osfamily = $::operatingsystem } } }

[alvagante]

I'm not using $osfamily to keep backwards compatibility with older facter versions (and because when I started to write these modules, $osfamily was not available yet or was just released). To set $osfamily in puppet code sounds a good idea but in order to make it useful and reusable it should be a top scope variable so it couldn't stay in any module.

So, for the moment, I would just patch the current modules extending the $operatingsystem matches with an extended list like the one you provided. In most of the cases it's quite easy and straightforward as it implies some entries to be added in params.pp If you need OracleLinux support for some modules just tell me which ones, or directly send your pull requests for quick inclusion in mainstream version.

[alvagante]

@supernovae Any feedback on this? I've not urgent need to support OracleLinux, but since the amount of work for a single module is trivial , if you need support for specific modules tell me (or PL your fixes)