Eric Larson
Eric Larson
Closing. Re-open if real-world example occurs.
A vanilla BL v7.33.1 install displays this issue, too. * Rails 7.0.4.2 * Blacklight 7.33.1 * blacklight_advanced_search 7.0.0
Forked the gem to work on a fix. Removed a lot of override code and most of the `_facet_limit.html.erb` view to make things right again: https://github.com/ewlarson/blacklight_advanced_search/tree/bl7-fix * Rails 7.0.4.2 *...
Okay! This branch is a good PR candidate: https://github.com/ewlarson/blacklight_advanced_search/tree/bl7-fix-gentle-hands * Removes the render_constraints_filters override method * Removes the _facet_limit.html.erb code that duplicates facet limits * Specs run green I don't...
I'm busy on a GeoBlacklight consulting gig at the moment, but when I find some extra time I'll cook one up. Unless someone beats me to it...
Sorry to confuse! Basically, this code: ``` ``` Produces this result Where the field's label is "Display Note" (my element.label value), but the add another link value doesn't use that...
Not so much a bug, but an oversight? Also, I18n would work great for everyone, except me pulling fields out of a database table.
If you pass in a field label, the add another link should use that same label. This isn't an attr_json issue, but an issue with the cocoon(-ish) repeatable element rendering...
Thanks for the comment! Yeah, I just think the field label and the repeatable field link text should be the same (do you have a case where that's not true?)....
I can confirm this issue. Thanks for writing it up!