hera icon indicating copy to clipboard operation
hera copied to clipboard

[WIP] Update WAVM to 7th Feb 2019

Open axic opened this issue 7 years ago • 5 comments

axic avatar Feb 08 '19 14:02 axic

@chfast apparently instead of this mess we do in the install scripts, the WAVM author suggests the following: https://github.com/WAVM/WAVM/issues/128

I'm not versed in cmake at all to know if that helps. Can you check?

axic avatar Feb 08 '19 14:02 axic

Codecov Report

Merging #493 into master will increase coverage by 0.98%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   51.18%   52.17%   +0.98%     
==========================================
  Files           8        8              
  Lines        1346     1311      -35     
  Branches      130      129       -1     
==========================================
- Hits          689      684       -5     
+ Misses        630      600      -30     
  Partials       27       27

codecov-io avatar Feb 08 '19 14:02 codecov-io

Can you check?

This will not work in our case unless you add it to Hunter.

chfast avatar Feb 08 '19 14:02 chfast

@chfast can you review this? My only requirement for this PR would be that we do not have larger memory leak due to our code than before.

axic avatar Feb 25 '19 10:02 axic

This is broken after the rebase 😢

axic avatar Feb 25 '19 10:02 axic