benchmarking icon indicating copy to clipboard operation
benchmarking copied to clipboard

Do not show charts at the end, close charts after being used

Open hugo-dc opened this issue 5 years ago • 4 comments

Fixes https://github.com/ewasm/benchmarking/issues/154

Also, closes all charts after being used in order to not retain in memory, avoiding the warning message RuntimeWarning: More than 20 figures have been opened. Figures created through the pyplot interface (matplotlib.pyplot.figure) are retained until explicitly closed and may consume too much memory. (To control this warning, see the rcParam figure.max_open_warning).

hugo-dc avatar Aug 13 '20 06:08 hugo-dc

This pull request introduces 104 alerts when merging d35b66fef8440956b5b54e208d0abe93edfc7f30 into a156a289b6b258f15777b72c798d1754f8721534 - view on LGTM.com

new alerts:

  • 53 for Use of the return value of a procedure
  • 51 for Variable defined multiple times

lgtm-com[bot] avatar Aug 13 '20 06:08 lgtm-com[bot]

This pull request introduces 4 alerts when merging d35a61e94b8fd6c137f8b6c900bef8a1245d34ab into f1ed8471ba4be3e31c4651de868c36ebf7c08d91 - view on LGTM.com

new alerts:

  • 3 for Use of the return value of a procedure
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Aug 15 '20 04:08 lgtm-com[bot]

This pull request introduces 4 alerts when merging ad90868d918312f81f968e6f30ca3f8673f44b92 into f1ed8471ba4be3e31c4651de868c36ebf7c08d91 - view on LGTM.com

new alerts:

  • 3 for Use of the return value of a procedure
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Aug 15 '20 04:08 lgtm-com[bot]

@jwasinger I created a Dockerfile to generate the charts in a docker instance, but it is generating the exact same files (no diff), I'll take a closer look at the CI and maybe try to use the same versions of the tools (OS, python, jupyter,etc).

hugo-dc avatar Aug 26 '20 19:08 hugo-dc