ENSwiftSideMenu icon indicating copy to clipboard operation
ENSwiftSideMenu copied to clipboard

click outside available

Open yatch999 opened this issue 9 years ago • 2 comments

Hi, I've updated outside tap to close menu. This edit points are 3.

clickOutsideClose : Bool (default = true)

it switches outside click availability. This function add a clear view. If you hope to avoid it, set clickOutsideClose = false.

evanz, Please check it. My editor add some a space, it makes many change point... So bad and excuse me.

yatch999 avatar Jan 17 '17 10:01 yatch999

Hi evanz, thanks to your comments. I agree all your review points.

Some guys like to implement "Click outside to Close menu", my code is only integrate in the past topics. (And my local project customize these points.)

Now, I received Pull Request for MY Folk from yours. Can I keep and maintain these actions? It will not make any impacts to your original codes.

yatch999 avatar Feb 05 '17 00:02 yatch999

@yatch999 Thank you very much for your Pull Request! :) But in the future please make sure the commit doesn't have all those useless lines modifications like new spaces or removing spaces. It's a waste of time :(

OxyFlax avatar Aug 17 '17 21:08 OxyFlax