Fixup trino.

[jpambrun]

Description

The trino driver didn't work for me.

1. https didn't work
2. passwordless auth didn't work
3. the SELECT 1; statement to test connection was giving me an error "failed to connect; line 1:9: mismatched input ';'. Expecting: '%', '*', '+', ',', '-', '.', '/', 'AND', 'AS', 'AT', 'EXCEPT', 'FETCH', 'FROM', 'GROUP', 'HAVING', 'INTERSECT', 'LIMIT', 'OFFSET', 'OR', 'ORDER', 'UNION', 'WHERE', 'WINDOW', '[', '||', , ,"

Checklist

• [ ] For UI or styling changes, I have added a screenshot or gif showing before & after
• [x] I have added a changeset
• [ ] I have added to the docs where applicable
• [ ] I have added to the VS Code extension where applicable

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 199257fbcb5b0be56985d203d56dbd812598c5d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@evidence-dev/trino	Patch
@evidence-dev/components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify[bot]]

✅ Deploy Preview for next-docs-evidence ready!

Name	Link
🔨 Latest commit	199257fbcb5b0be56985d203d56dbd812598c5d1
🔍 Latest deploy log	https://app.netlify.com/sites/next-docs-evidence/deploys/669fb87ced36330008eaf377
😎 Deploy Preview	https://deploy-preview-1996--next-docs-evidence.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify[bot]]

✅ Deploy Preview for evidence-development-workspace ready!

Name	Link
🔨 Latest commit	199257fbcb5b0be56985d203d56dbd812598c5d1
🔍 Latest deploy log	https://app.netlify.com/sites/evidence-development-workspace/deploys/669fb87c07469e00081e6141
😎 Deploy Preview	https://deploy-preview-1996--evidence-development-workspace.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify[bot]]

✅ Deploy Preview for evidence-test-env ready!

Name	Link
🔨 Latest commit	199257fbcb5b0be56985d203d56dbd812598c5d1
🔍 Latest deploy log	https://app.netlify.com/sites/evidence-test-env/deploys/669fb87c7833d500085063a9
😎 Deploy Preview	https://deploy-preview-1996--evidence-test-env.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ItsMeBrianD]

Hey @jpambrun!

Thanks for submitting this, appreciate the notes on what the changes were for as well. One thing missing is a changeset, we have instructions on adding one in CONTRIBUTING.md

It also looks like you need to run pnpm i from the root of the monorepo, it should update pnpm-lock.yaml - this is why the tests are failing right now

[archiewood]

@jpambrun do you still want to take a look at this?

[jpambrun]

It's still needed. I also need to increase the timeout which was only 60sec by default.

I haven't had time to look at the contributing documentation. I am using patch-package to fix it on my side. I was/am happy to help, but with no real internal motivation it hard to find time.

[archiewood]

I think it just needs:

1. a changeset pnpm changeset
2. to update the package-lock pnpm i

and then it will pass tests

[jpambrun]

Hey. This is a bit cumbersome.. first the "main" branch in github is next, so when I fork this is what I get to base a new branch from, but later changeset is not happy.

It's also not happy in the "lint & formatting" with my lock file, maybe?

[jpambrun]

Also, should MR target main or next?

[archiewood]

next is the correct target

i'll take a look at the linter

[jpambrun]

When I ran change set it complained that I didn't have a main branch since my fork only brought "next" over. Is that expected?

Also the linter and UI test are failing due to some lock/node version error, not because of formatting (although it's fair to expect some formatting issues).

On Sat, Jun 1, 2024, 11:36 PM Archie Sarre Wood @.***> wrote:

next is the correct target

the linter can be fixed with pnpm run format (or i can do this)

— Reply to this email directly, view it on GitHub https://github.com/evidence-dev/evidence/pull/1996#issuecomment-2143683454, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFPMMEAI2K4OP2FQVGJAI3ZFKHMDAVCNFSM6AAAAABHS3B6V6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGY4DGNBVGQ . You are receiving this because you were mentioned.Message ID: @.***>

[zachstence]

@jpambrun There are merge conflicts in pnpm-lock.yaml that need to be resolved before this can be merged.

To resolve them:

1. Merge evidence-dev:next into your branch
2. Delete pnpm-lock.yaml
3. Run pnpm i --ignore-scripts
4. Run git add .
5. Run git merge --continue
6. Run git push

Let me know if you're having any trouble!

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
evidence-evidence	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 23, 2024 2:08pm