generated tabs are broken in latest update

[fboerman]

Steps To Reproduce

generate tabs from a query like this:

<Tabs>
{#each hubs as hub}
<Tab label="{hub.hub}">

<LineChart
  data={np_combined.where(`hub = '${hub.hub}' `)}
  x=mtu
  y={["NP", "min_np", "max_np"]}
  step=true
  chartAreaHeight=300
  yFmt={`0 "MW"`}
  title="Net Position of {hub.hub} in CORE for {params.businessday} within its theoretical boundaries"
  colorPalette={amunColors}
/>

<LineChart
  data={np_util.where(`hub = '${hub.hub}' `)}
  x=mtu
  y=util_pct
  step=true
  title="Net Position of {hub.hub} in CORE for {params.businessday} as percentage of min/max"
  sort=false
  yMin=0
  yMax=1
  yFmt="pct2"
/>

</Tab>
{/each}
</Tabs>

Environment

• Node version (node -v): v20.12.2
• npm version (npm -v): 10.5.2
• OS: archlinux
• Browser: firefox
• Database: postgres (but probably unrelated)

Expected Behavior

tabs to generate with names

Actual Behaviour

tabs look like below and the content of all tabs is generated below eachother

Workarounds

none that I know of so far

[fboerman]

update after talking to @hughess it probably has to do with not waiting for query result. because generating tabs in a loop like this works:

<Tabs>
{#each ['one', 'two'] as tab}
<Tab label={tab}>

  content {tab}

</Tab>
{/each}
</Tabs>

[archiewood]

Note that you should always use {#each} blocks wrapped in newlines like this

<Tabs>

{#each ['one', 'two'] as tab}

<Tab label={tab}>

  content {tab}

</Tab>

{/each}

</Tabs>

reason: markdown is newline sensitive

[fboerman]

hi @archiewood that doesnt actually fix my issue so I dont understand why you are closing this? the bug still exists

[archiewood]

Sorry, didn't mean to close, hit the wrong button on mobile

[ItsMeBrianD]

Should follow up post-release to confirm, but this should be addressed by the fixes in #1980

[mcrascal]

@ItsMeBrianD - still occurring on next afaict