hide.client.linux icon indicating copy to clipboard operation
hide.client.linux copied to clipboard

scripts uses bash idioms in ash script

Open solsticedhiver opened this issue 1 year ago • 0 comments

the scripts in scripts directory use a lot of bash idioms that will only run in bash and not ash or dash.

Please use bash in shellbang instead.

Some example:

  • if [[ ]] is bash only use if [ ] instead
  • accessToken=${accessToken//"\""/} string replacement is not available

Possible bug:

line 22 of hideme-accesToken.ash: if [[ $? == "22" ]];

You compare the output result which is an integer to a string. that will always be false. Use something like if [ $? -eq 22 ] of better if [ $? -ne 0 ]

solsticedhiver avatar May 09 '24 12:05 solsticedhiver