node-ftpsync icon indicating copy to clipboard operation
node-ftpsync copied to clipboard

Pass path to config.json as argument

Open laurentvd opened this issue 10 years ago • 2 comments

Great work on the module. Really dig its simplicity. Small improvement request: being able to pass the filename of the config.json file. I have so many other stuff in the root of my project, and it would be great if we could change it. Other than that, love it!

laurentvd avatar Mar 30 '16 21:03 laurentvd

@laurentvd Honestly, I was considering moving the config.json parameters into package.json. The only issue I see there is protecting the login credentials.

In the mean time it shouldn't be difficult to add the config filename as a configurable parameter.

evanplaice avatar Apr 20 '16 23:04 evanplaice

Agreed. I think encouraging users to protect their credentials is a good thing. Maybe even suggest to put the default config.json in .gitignore and add a config.example.json to the VCS.

laurentvd avatar Apr 21 '16 08:04 laurentvd