logrus_fluent icon indicating copy to clipboard operation
logrus_fluent copied to clipboard
verified publisher icon evalphobia

Just use one connection..

Open thinkong opened this issue 10 years ago • 3 comments

I noticed that it is currently connecting everytime it writes something to logrus.. which in my opinion it shouldn't do..

this is a pull request to make a connection when creating a new hook and using that connection for every Fire

thinkong avatar Feb 23 '16 06:02 thinkong

Thanks! :smile: I could not run the test it my local environment. Did you pass it?

evalphobia avatar Feb 23 '16 15:02 evalphobia

hmm.. wonder why it's not passing the test..
I'll look into it again when I have the chance..

thinkong avatar Feb 24 '16 06:02 thinkong

@thinkong sorry for my late reply. I checked the test and modified for one connection in #8 . I add new api New() as your intention, but I feel sorry not to merge your this PR 😢 . Thank you for your contribution :blush:

evalphobia avatar Aug 27 '16 15:08 evalphobia