Replace parseurl with WHATWG URL API
More information here:
https://github.com/e18e/ecosystem-issues/issues/160
Stale pull request message
Stale pull request message
Stale pull request message
Hmm, ok? :)
Stale pull request message
Do you need something from me to make this PR easier to close?
Hi @Saturate
Copilot actually caught a real issue here.
-
thisisn’t a URL, it’s a request object, so you should usenew URL(this.url). -
Also,
this.urlmight not always be an absolute URL.parseurlhandled relative ones fine, but the URL constructor doesn’t. Adding a base URL (like Copilot suggested) will make sure relative URLs work correctly and avoid potential problems.
Example:
const req = {
url: '/some/path?name=foo',
}
console.log(parse(req).pathname); // Output: '/some/path'
console.log(new URL(req.url).pathname); // TypeError: Invalid URL