HLSLDecompiler icon indicating copy to clipboard operation
HLSLDecompiler copied to clipboard

Fix some bugs

Open pema99 opened this issue 3 years ago • 0 comments

Hey. This looks pretty abandoned, but in case it isn't, I made a few fixes.

  • When building on newer versions of VS using Windows 10, I ran into to issues that required including a few more headers.

  • The DXBC binaries I was looking at would sometimes use uppercase CB when declaring constant buffers. I made the code that parses these case insensitive.

  • mCBufferNames is never empty since an entry is added explicitly in ParseBufferDefinitions. I changed a check that relies on it being empty to account for this. This lets the binaries I was reversing successfully decompile, since the explicit cbuffer info in comments isn't present for them.

I'm guessing this won't be merged, but I hope this might help people trying to use this in the future.

pema99 avatar Aug 02 '22 00:08 pema99