ENG-2185

[JadeCara]

Ticket ENG-2185

Description Of Changes

This ticket was originally asking for consent manual tasks. We are going forward with a work around #7102 because consent task graphs and access/erasure task graphs are different and have different capabilities - especially around conditional dependencies.

There are going to be a few PRs cleaning up some un-used functionality or adjusting functionality for improved usage patterns. This PR removes the Manual Tasks Logs table as the first step in getting manual tasks and conditions into shape for the above requirements. It is a clean up based on the first few rounds of customer use and learning actual usage patterns.

This PR:

• The logging being used by manual tasks and front end data is entirely the general audit logs so the manual task log table and utilities are now redundant.

Future PRs:

• Update the Conditional Dependency table with a JSONB dictionary column instead of having each dependecy create its own row. #7117
• Allow conditional dependencies to be assigned to a specific policy type or id
• Allow users to be assigned to specific submissions rather than the whole task.

Code Changes

• .fides/db_dataset.yml - removed ManualTaskLog table
• src/fides/api/alembic/migrations/versions/ remove the manual task table.
• src/fides/api/db/base.py - removed ManualTaskLog
• src/fides/api/models/manual_task/manual_task.py removed the log class and updated the functions where manual task logs were created.
• Updated all tests removing the manual task log.

Steps to Confirm

1. There should be NO change in functionality.
2. Manual tasks, conditional dependencies etc should continue to function as before.
3. Please test with FidesPlus 2920
4. Run FidesPlus branch above pointed at this branch.
5. Create a ManualTask with several submissions required and several conditions, both dataset and privacy request based.
6. Create privacy requests that meet and do not meet the requirements. Verify that they create/do not create as expected.
7. Verify that you can complete the manual tasks with no errors.
8. Verify that you can see the skipped logs and the manual task and manual task actions appear on the DSR activity log.
9. Verify that you receive the access package with all expected manual task inclusions (attachments and text)
10. Update the ManualTask submission types, delete one or more.
11. Delete manual task integration

Pre-Merge Checklist

• [ ] Issue requirements met
• [ ] All CI pipelines succeeded
• [ ] CHANGELOG.md updated
  • [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
  • [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • [ ] Updates unreleased work already in Changelog, no new entry necessary
• UX feedback:
  • [ ] All UX related changes have been reviewed by a designer
  • [ ] No UX review needed
• Followup issues:
  • [ ] Followup issues created
  • [ ] No followup issues
• Database migrations:
  • [ ] Ensure that your downrev is up to date with the latest revision on main
  • [ ] Ensure that your downgrade() migration is correct and works
    • [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
  • [ ] No migrations
• Documentation:
  • [ ] Documentation complete, PR opened in fidesdocs
  • [ ] Documentation issue created in fidesdocs
  • [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • [ ] No documentation updates required