fides
fides copied to clipboard
Add keyboard accessible CustomTooltip HOC
Closes ENG-849
Description Of Changes
Introduces a new Higher-Order Component (HOC) CustomTooltip that wraps the Ant Design Tooltip to provide enhanced keyboard accessibility. This HOC automatically adds a tabIndex to non-focusable elements, allowing them to receive focus and trigger the tooltip. It also applies a custom focus-visible style for better visibility.
Code Changes
-
fidesui- Added a new
CustomTooltipHOC that automatically provides keyboard accessibility (focus trigger,tabIndex) to Ant Design's Tooltip. - Exported
CustomTooltipas the defaultAntTooltipfrom thefidesuilibrary.
- Added a new
-
admin-ui- Updated the POC page to demonstrate the new tooltip behaviors.
- Added theme overrides for the
Tagcomponent.
Steps to Confirm
- Navigate to the Ant components POC page at
/poc/ant-components. - Hover over the various tooltipped elements to confirm the tooltips appear as expected.
- Use the
Tabkey to navigate the page. - Confirm that the text "Hover or focus this text" receives focus, shows a dashed outline, and displays its tooltip.
- Confirm that the "Button with tooltip" also receives focus and displays its tooltip, but without the custom dashed outline.
Pre-Merge Checklist
- [x] Issue requirements met
- [ ] All CI pipelines succeeded
- [x]
CHANGELOG.mdupdated- [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
- [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
- [ ] Updates unreleased work already in Changelog, no new entry necessary
- Followup issues:
- [ ] Followup issues created
- [x] No followup issues
- Database migrations:
- [ ] Ensure that your downrev is up to date with the latest revision on
main - [ ] Ensure that your
downgrade()migration is correct and works- [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
- [x] No migrations
- [ ] Ensure that your downrev is up to date with the latest revision on
- Documentation:
- [ ] Documentation complete, PR opened in fidesdocs
- [ ] Documentation issue created in fidesdocs
- [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
- [x] No documentation updates required
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| fides-plus-nightly | ⬜️ Ignored (Inspect) | Visit Preview | Jun 27, 2025 11:23pm | |
| fides-privacy-center | ⬜️ Ignored (Inspect) | Jun 27, 2025 11:23pm |
fides
Run #13037
Run Properties:
Passed #13037 •
029dc8a6fa: Add keyboard accessible CustomTooltip HOC (#6276)
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 53s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |