fides icon indicating copy to clipboard operation
fides copied to clipboard
verified publisher icon ethyca

Migrate tabs to Ant Design

Open jpople opened this issue 7 months ago • 1 comments

Closes ENG-158

Description Of Changes

Migrates all Chakra tabs in the admin UI to Ant Design's Tabs component, and implements a reusable hook to handle hashing tab URLs.

Steps to Confirm

  1. General regression (especially around URL hashing)

Pre-Merge Checklist

  • [x] Issue requirements met
  • [ ] All CI pipelines succeeded
  • [ ] CHANGELOG.md updated
    • [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
    • [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • [ ] Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • [ ] Followup issues created
    • [ ] No followup issues
  • Database migrations:
    • [ ] Ensure that your downrev is up to date with the latest revision on main
    • [ ] Ensure that your downgrade() migration is correct and works
      • [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
    • [ ] No migrations
  • Documentation:
    • [ ] Documentation complete, PR opened in fidesdocs
    • [ ] Documentation issue created in fidesdocs
    • [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • [ ] No documentation updates required

jpople avatar Jun 23 '25 19:06 jpople

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2025 6:54pm
fides-privacy-center ⬜️ Ignored (Inspect) Jul 9, 2025 6:54pm

vercel[bot] avatar Jun 23 '25 19:06 vercel[bot]

@lucanovera Thanks for catching that, I've updated to fix the action center tabs and fixed the remaining test failures.

jpople avatar Jul 01 '25 23:07 jpople

fides    Run #13096

Run Properties:  status check failed Failed #13096  •  git commit 0b2a640adc: Migrate tabs to Ant Design (#6260)
Project fides
Branch Review main
Run status status check failed Failed #13096
Run duration 01m 50s
Commit git commit 0b2a640adc: Migrate tabs to Ant Design (#6260)
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/smoke_test.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Smoke test > can access Mongo and Postgres connectors from the Admin UI > can access Postgres connectors from the Admin UI Screenshots Video
Smoke test > can access Mongo and Postgres connectors from the Admin UI > can access Mongo connectors from the Admin UI Screenshots Video

cypress[bot] avatar Jul 09 '25 20:07 cypress[bot]