fides icon indicating copy to clipboard operation
fides copied to clipboard

ENG-762 Send message to newly assigned users

Open JadeCara opened this issue 7 months ago • 3 comments

Issue ENG-762

Description Of Changes

Adds a the functionality to send an assignment message to users who have just been assigned a task. Includes email template html and tests.

Code Changes

  • Added new function _send_task_assignment_notifications which is a new helper task which will automatically be called when new users are assigned to a task.
  • Added email templating functionality
  • Added email template
  • Added test.

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • [ ] Issue requirements met
  • [ ] All CI pipelines succeeded
  • [ ] CHANGELOG.md updated
    • [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
    • [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • [ ] Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • [ ] Followup issues created
    • [ ] No followup issues
  • Database migrations:
    • [ ] Ensure that your downrev is up to date with the latest revision on main
    • [ ] Ensure that your downgrade() migration is correct and works
      • [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
    • [ ] No migrations
  • Documentation:
    • [ ] Documentation complete, PR opened in fidesdocs
    • [ ] Documentation issue created in fidesdocs
    • [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • [ ] No documentation updates required

JadeCara avatar Jun 20 '25 13:06 JadeCara

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2025 3:32am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-privacy-center ⬜️ Ignored (Inspect) Jun 21, 2025 3:32am

vercel[bot] avatar Jun 20 '25 13:06 vercel[bot]

Codecov Report

:x: Patch coverage is 24.24242% with 25 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 86.07%. Comparing base (2be2db6) to head (e696e28). :warning: Report is 184 commits behind head on main.

Files with missing lines Patch % Lines
.../fides/service/manual_tasks/manual_task_service.py 0.00% 23 Missing :warning:
...rc/fides/api/email_templates/get_email_template.py 33.33% 1 Missing and 1 partial :warning:

:x: Your patch status has failed because the patch coverage (24.24%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6253      +/-   ##
==========================================
- Coverage   86.15%   86.07%   -0.08%     
==========================================
  Files         448      448              
  Lines       28027    28059      +32     
  Branches     3025     3029       +4     
==========================================
+ Hits        24146    24153       +7     
- Misses       3229     3253      +24     
- Partials      652      653       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 20 '25 13:06 codecov[bot]

I think this needs to be updated to make sure its working with the respondents email verification stuff - https://github.com/ethyca/fides/blob/f704c4f8c6348901826e5fc9e188d14aab0d81a3/src/fides/api/models/fides_user_respondent_email_verification.py

JadeCara avatar Jun 20 '25 17:06 JadeCara

We send the user an invite when we create the user in Fides. The API endpoints also let you resend the invite link, in essence, a re-invitation. We need to spend some time creating a digest of pending tasks so we don't send an email every time a new privacy request is created.

galvana avatar Jul 02 '25 19:07 galvana