fides icon indicating copy to clipboard operation
fides copied to clipboard

privacy creates manual task instances

Open JadeCara opened this issue 7 months ago • 2 comments

Issue ENG-762

Description Of Changes

When a privacy request is created - if it has any ManualTaskConfigs with manual tasks and configs set up, it will create an instance for completion.

Code Changes

  • Added functionality to privacy_request_service That will create a manual_task_instance for that privacy request if there is a manual task connection, with task and config set up.

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • [ ] Issue requirements met
  • [ ] All CI pipelines succeeded
  • [ ] CHANGELOG.md updated
    • [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
    • [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • [ ] Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • [ ] Followup issues created
    • [ ] No followup issues
  • Database migrations:
    • [ ] Ensure that your downrev is up to date with the latest revision on main
    • [ ] Ensure that your downgrade() migration is correct and works
      • [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
    • [ ] No migrations
  • Documentation:
    • [ ] Documentation complete, PR opened in fidesdocs
    • [ ] Documentation issue created in fidesdocs
    • [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • [ ] No documentation updates required

JadeCara avatar Jun 19 '25 21:06 JadeCara

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 7:18pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-privacy-center ⬜️ Ignored (Inspect) Jun 20, 2025 7:18pm

vercel[bot] avatar Jun 19 '25 21:06 vercel[bot]

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 86.53%. Comparing base (f704c4f) to head (fd6f325). Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...service/privacy_request/privacy_request_service.py 40.00% 14 Missing and 1 partial :warning:

:x: Your patch status has failed because the patch coverage (40.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6252      +/-   ##
==========================================
+ Coverage   86.15%   86.53%   +0.38%     
==========================================
  Files         448      448              
  Lines       28027    28052      +25     
  Branches     3025     3029       +4     
==========================================
+ Hits        24146    24276     +130     
+ Misses       3229     3122     -107     
- Partials      652      654       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 19 '25 21:06 codecov[bot]

This was covered by other PRs, closing out

galvana avatar Jul 02 '25 19:07 galvana