fides icon indicating copy to clipboard operation
fides copied to clipboard

Use CheckboxTree for data map filtering

Open gilluminate opened this issue 1 year ago • 2 comments

Closes PROD-1916

Description Of Changes

Update the filters on the table to apply a modified version of the hierarchy component that we are using on the dataset page.

Code Changes

Steps to Confirm

Pre-Merge Checklist

  • [ ] All CI Pipelines Succeeded
  • [ ] Issue Requirements are Met
  • [ ] Update CHANGELOG.md

gilluminate avatar May 04 '24 00:05 gilluminate

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 10:53pm

vercel[bot] avatar May 04 '24 00:05 vercel[bot]

Passing run #7628 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 289630a92d97db14610c86716ca7b089107564b5 into 0e27b2189e97b98347de649c33d3...
Project: fides Commit: a5edc3e913 ℹ️
Status: Passed Duration: 00:33 💡
Started: May 7, 2024 11:02 PM Ended: May 7, 2024 11:03 PM

Review all test suite changes for PR #4864 ↗︎

cypress[bot] avatar May 04 '24 00:05 cypress[bot]

  1. The vertical spacing between items within the accordions seems uneven:

I think that was existing, but it's an easy fix. Great catch.

gilluminate avatar May 07 '24 22:05 gilluminate

  1. The group_by query param seems to have some encoding issues in the resulting API call:

That's also existing behavior, and I'm worried about breaking it for the backend. Might be best to re-ticket that one as you suggested.

gilluminate avatar May 07 '24 22:05 gilluminate