Adding ability to delete properties
Closes PROD-1664
Description Of Changes
Adding the ability to delete properties, only available to owners and contributors. Verifies that all of the experiences on the property are unlinked before being able to delete the property.
Code Changes
- [ ] Added delete button to property table rows and property edit page
- [ ] Removed the cascade deletes between
plus_property,plus_privacy_experience_config_propertyto avoid putting the property/privacy_experience_config entries into an invalid state
Steps to Confirm
- [ ] Start fidesplus off of the branch in https://github.com/ethyca/fidesplus/pull/1353
- [ ] Start the Admin UI in this PR
- [ ] Create a property without privacy experiences
- [ ] Create a property with at least one privacy experience
- [ ] Verify the delete buttons in the rows and edit page are disabled/enabled according to the state of the properties
Pre-Merge Checklist
- [ ] All CI Pipelines Succeeded
- [ ] Issue Requirements are Met
- [ ] Update
CHANGELOG.md
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| fides-plus-nightly | ⬜️ Ignored (Inspect) | Visit Preview | Mar 21, 2024 4:54pm |
Passing run #6806 ↗︎
| ⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results. | ||||
Details:
| Merge b662038ea8b9052aca29c2fb804294ba5f316163 into 0b1b99475d1e185504ca4db46f8b... | |||
| Project: fides | Commit: 5b739fb3d0 ℹ️ |
||
| Status: Passed | Duration: 00:34 💡 | ||
| Started: Mar 21, 2024 5:05 PM | Ended: Mar 21, 2024 5:05 PM | ||
Review all test suite changes for PR #4708 ↗︎
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.63%. Comparing base (
ccd14a7) to head (a1d476d).
Additional details and impacted files
@@ Coverage Diff @@
## main #4708 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 337 337
Lines 19977 19977
Branches 2551 2551
=======================================
Hits 17308 17308
Misses 2201 2201
Partials 468 468
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
AC
✅ When a property exists and I view the details of it, then a delete button is shown on the bottom left of the screen.
✅ When a property exists but is NOT referenced by a privacy experience, then I can delete the property.
✅ When a property exists, but is referenced by a privacy experience, then I cannot delete it.
Stretch AC
✅ When a property exists that cannot be deleted, then the UI provides a tooltip explaining what to do in order to delete the property.