Multi-value support for custom privacy request fields
Closes PROD-1802
Description Of Changes
Adding support for multi-value custom privacy request fields (integers and strings). This PR only covers the affected API endpoints and the part of the Admin UI responsible for displaying the custom fields. Changes to allow the Privacy Center forms to support multi-values fields is covered here https://ethyca.atlassian.net/browse/PROD-1807.
Code Changes
- [ ] Updating the Admin UI to display custom privacy request field values correctly as comma separated values
- [ ] Updated the functions responsible for caching and persisting custom values to the database to support lists
- [ ] Updated the
assign_placeholdersutil function to support list values - [ ] Updated related tests and added multi-value scenarios
Steps to Confirm
- [ ] list any manual steps for reviewers to confirm the changes
Pre-Merge Checklist
- [ ] All CI Pipelines Succeeded
- Documentation:
- [ ] documentation complete, PR opened in fidesdocs
- [ ] documentation issue created in fidesdocs
- [ ] Issue Requirements are Met
- [ ] Relevant Follow-Up Issues Created
- [ ] Update
CHANGELOG.md - [ ] For API changes, the Postman collection has been updated
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| fides-plus-nightly | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 21, 2024 4:05pm |
Passing run #6791 ↗︎
| ⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results. | ||||
Details:
| Merge 5c3f28ca9c5279d41b07133bb6e55e67ee4ad0b0 into ccd14a7edb80bdb95e4358003773... | |||
| Project: fides | Commit: 1ba111379e ℹ️ |
||
| Status: Passed | Duration: 00:34 💡 | ||
| Started: Mar 20, 2024 8:37 PM | Ended: Mar 20, 2024 8:38 PM | ||
Review all test suite changes for PR #4686 ↗︎
Codecov Report
Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 86.64%. Comparing base (
ccd14a7) to head (5c3f28c).
| Files | Patch % | Lines |
|---|---|---|
| src/fides/api/models/privacy_request.py | 93.75% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #4686 +/- ##
=======================================
Coverage 86.63% 86.64%
=======================================
Files 337 337
Lines 19977 19990 +13
Branches 2551 2555 +4
=======================================
+ Hits 17308 17320 +12
Misses 2201 2201
- Partials 468 469 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.