ethyca
Configure Connector after creation
Backend work found in #1227
USER STORY
As an admin, I want to a be able to update a connector after creation.
AC
- in the meatball menu for a connector in the Datastore Connections tab, add Configure option
- reuse the connector's creation form pre-populated with the current data
- fix the bug that throws an error when you hit save twice - aka allow for updates
DESIGNS
https://www.figma.com/file/4qgQpYc1bX4dXg2PHmRORL/DSR-Error-Handling?node-id=88%3A4993
Extra Info
reach out to design to discuss this as a drawer to make the work easier and design more consistent
Consider masking api keys so that the data can persist and not be removed when a user wants to simply edit the title. We can add a separate user story for this.
FYI there are 2 separate endpoints to save 1. the name and other config 2. the secrets
See PATCH /api/v1/connection and PUT /api/v1/connection/{connection_key}/secret
We will likely need to update the second endpoint to a patch
@mfbrown @Kelsey-Ethyca @renderbits @adamczepeda I have a few questions I would like to get some feedback. Please let me know if I should schedule a meeting to walkthrough each item .
- When creating a DB connection should I display a toast informing the user that the connection was created if the config secrets fail to save?
NOTE: Currently, the UI makes 2 separate API calls from the FE to the BE to create a connection and save the config secrets. Each API call is mutually exclusive. My upcoming commit does NOT display a toast for a connection created if the config secrets fail to save.
- Should we auto redirect the user to the Dataset configuration or DSR customization form after the user clicks the Save button via the Connector parameters form upon creating a Manual, Database, or 3rd party integration (Says) connection type?
NOTE: Currently, the user is auto redirected. Given the auto redirect the user cannot click the Test connection button for a Database or Saas connection on the Connector parameters screen after clicking the Save button initially. After the auto redirect the user can navigate manually to the Connector parameters form via left hand side navigation and click the Test connection button.
- When editing a Manual connector connection, should the following statement be omitted?
To begin setting up your new Manual Webhook connector you must first assign a name to the connector and a description.
Please suggest additional verbiage if needed.
- On the Datastore Connections landing page if a given connection does not have a description supplied, should I create an empty placeholder within the given connection card?
