dora icon indicating copy to clipboard operation
dora copied to clipboard

Add docker desktop support, tested on macOS Sonoma

Open antojoseph opened this issue 1 year ago • 4 comments

Hi ,

On Docker Desktop, the IP's allocated to EL/CL clients are not accessible to the host. As such, when you try make devnet-run , you do get dora on 12.0.0.1:8080, but it can't reach any clients.

The Fix I have added a bash script run_dd.sh to .hack/devnet directory. This script bootstraps dora with the local ip and correct ports for EL/CL clients on docker desktop. I have also added a devnetdd and devnetdd-run command to the Make file so developers can quickly iterate on this.

Please let me know if there are any questions. Adding screenshot of dora running with the devnetdd-run command in this PR Screenshot 2024-07-27 at 3 49 52 AM

antojoseph avatar Jul 26 '24 22:07 antojoseph

You can ignore the changes in run.sh, I mainly used it for testing :)

antojoseph avatar Jul 26 '24 22:07 antojoseph

Hey @antojoseph . Thanks for the PR!

Your approach using the port mappings works for both versions (Docker Desktop / Orbstack). So I would prefer if we actually make it the default for the run.sh script, so that we don't have 2 separate scripts just for that. Updating the current run.sh with the content of you run_dd.sh should be enough. Also getting rid of any dd specific targets on the Makefile.

skylenet avatar Jul 30 '24 13:07 skylenet

Thanks @skylenet for the review. This does make sense. I will update the PR shortly :)

antojoseph avatar Aug 04 '24 04:08 antojoseph

@skylenet Updated PR with changes to just run.sh file. LMK if this looks good.

antojoseph avatar Aug 15 '24 05:08 antojoseph

works fine for me (debian + docker daemon)

pk910 avatar Aug 17 '24 11:08 pk910