itu icon indicating copy to clipboard operation
itu copied to clipboard

Version 1.10.1 and 1.10.2 have wrong java 9 module descriptor

Open aleruz-dt opened this issue 1 year ago • 2 comments

While version 1.10.0 has

module com.ethlo.time {
    exports com.ethlo.time;
}

as module descriptor, version 1.10.1 and 1.10.2 has

module com.ethlo.time {
    exports com.ethlo.time.token;
}

and this breaks the usage of the library in combination, for example, with json-schema-validator

Forcing the usage of version 1.10.0 makes it work again.

aleruz-dt avatar Jul 25 '24 12:07 aleruz-dt

I have no experience with how the OSGI modules should be packaged. I get a warning that there is a private reference to the package com.ethlo.time.token after this change.

ethlo avatar Jul 25 '24 19:07 ethlo

I can try it, if you publish a version, maybe better a RC. To verify locally, you can check the module-info.java file present in the META-INF/versions/9 directory.

I have no experience with the maven plugins you are using, so I can't help there.

aleruz-dt avatar Jul 25 '24 20:07 aleruz-dt

Sorry for the long delay. Is this working now, in version 1.10.3?

ethlo avatar Jan 07 '25 11:01 ethlo

It still fails. Checking the module descriptor, it is still the same.

aleruz-dt avatar Jan 27 '25 09:01 aleruz-dt

The maven module you're using only adds the last 'exports' specified to the generate module-info.java You should really just update the project to at least jdk17 because we're several LTS into the future.

lscoughlin avatar Feb 09 '25 20:02 lscoughlin

Thanks for the feedback.I have updated the project to use Java 11 from release 1.11.0.

ethlo avatar Feb 11 '25 08:02 ethlo