bee icon indicating copy to clipboard operation
bee copied to clipboard

enable paralleltest lint check in `pkg/postage`

Open vladopajic opened this issue 2 years ago • 2 comments

Currently pkg/postage has disabled paralleltest lint check (see golangci.yaml file). This check should be enabled for this package and tests should be corrected to use t.Parallel().

Acceptance criteria:

  • enable paralleltest lint check in pkg/postage
    • all tests should use t.Parallel(); if tests for some reason could not use t.Parallel() then it disabling lint check per tests case should be alright
  • all tests should pass
  • there should be no lint errors

vladopajic avatar Feb 24 '23 08:02 vladopajic

@vladopajic From what I understand, the issue here is to add t.parallel() to the test functions in pkg/postage right? Also, how do I enable paralleltest for pkg/postage? Do I make changes to the golangci.yml file?

emekaokoli19 avatar Feb 24 '23 15:02 emekaokoli19

@emekaokoli19 You are right on everything :)

vladopajic avatar Feb 24 '23 15:02 vladopajic