execution-spec-tests icon indicating copy to clipboard operation
execution-spec-tests copied to clipboard

:bricks: Feature: Add the go-ethereum `evm blocktest` within tox

Open spencer-tb opened this issue 2 years ago • 2 comments

Feature Description

We have the occasional case where we may generate an invalid test fixture. Currently test fixtures can be checked for validity using the:

evm blocktest <path_to_fixture.json>

command from go-ethereum's evm.

To check the validity of all tests after generation, we could add an additional step during tox, that runs the above command on every generated fixture.

spencer-tb avatar Aug 01 '23 16:08 spencer-tb

This will actually execute all the tests against geth, which might be overkill for our usual test.yaml workflow.

We could perhaps:

  1. Add a new tox environment that doesn't get ran by default, like testenv:tests-develop added in #302.
  2. Execute this test environment in a dedicated ci workflow. I'm not sure what this would look like, something executes daily on main and all branches from open PRs could be nice?

danceratopz avatar Sep 26 '23 07:09 danceratopz

This sounds like a great option 💯

spencer-tb avatar Sep 26 '23 22:09 spencer-tb