execution-spec-tests icon indicating copy to clipboard operation
execution-spec-tests copied to clipboard

tooling(fix): use --version instead of -v for version checking t8n tool

Open felix314159 opened this issue 9 months ago • 0 comments

🗒️ Description

Geth's evm supports both -v and --version but Nethermind's nethtest only supports --version. This does not mean that we can consume direct with nethtest now, but it's one of multiple fixes we must make. Next thing to work on would be assert cls.detect_binary_pattern is not None -> AttributeError: type object 'CollectOnlyFixtureConsumer' has no attribute 'detect_binary_pattern' to eventually enabling consume direct via nethtest

🔗 Related Issues

✅ Checklist

  • [ ] All: Set appropriate labels for the changes.
  • [ ] All: Considered squashing commits to improve commit history.
  • [ ] All: Added an entry to CHANGELOG.md.
  • [ ] All: Considered updating the online docs in the ./docs/ directory.
  • [ ] Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • [ ] Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • [ ] Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • [ ] Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

felix314159 avatar May 08 '25 10:05 felix314159