feat(forks): Implement `transition_time` method
🗒️ Description
• Added transition_time() in the Paris class to return the transition timestamp 15_000.
• Currently, it is only implemented in the Paris class, and I’d like to know if it should be moved to BaseFork or stay specific to Paris class. Seeking feedback on where to add this method in BaseFork for global usage across forks.
🔗 Related Issues
#1472
✅ Checklist
- [ ] All: Set appropriate labels for the changes.
- [ ] All: Considered squashing commits to improve commit history.
- [ ] All: Added an entry to CHANGELOG.md.
- [ ] All: Considered updating the online docs in the ./docs/ directory.
Thanks! I think this method should instead live in the https://github.com/ethereum/execution-spec-tests/blob/main/src/ethereum_test_forks/transition_base_fork.py file and follow the same pattern as transitions_to/transitions_from:
https://github.com/ethereum/execution-spec-tests/blob/2201c2e1c3cae5d5c2a2af12c025446845cf1069/src/ethereum_test_forks/transition_base_fork.py#L15-L23
https://github.com/ethereum/execution-spec-tests/blob/2201c2e1c3cae5d5c2a2af12c025446845cf1069/src/ethereum_test_forks/transition_base_fork.py#L97-L98
Sorry for the delay—does this look correct now?
Stale. But let's keep issue ethereum/execution-specs#1540 open