execution-spec-tests icon indicating copy to clipboard operation
execution-spec-tests copied to clipboard

feat(forks): Implement `transition_time` method

Open ArunRawat404 opened this issue 9 months ago • 2 comments

🗒️ Description

• Added transition_time() in the Paris class to return the transition timestamp 15_000. • Currently, it is only implemented in the Paris class, and I’d like to know if it should be moved to BaseFork or stay specific to Paris class. Seeking feedback on where to add this method in BaseFork for global usage across forks.

🔗 Related Issues

#1472

✅ Checklist

  • [ ] All: Set appropriate labels for the changes.
  • [ ] All: Considered squashing commits to improve commit history.
  • [ ] All: Added an entry to CHANGELOG.md.
  • [ ] All: Considered updating the online docs in the ./docs/ directory.

ArunRawat404 avatar May 03 '25 19:05 ArunRawat404

Thanks! I think this method should instead live in the https://github.com/ethereum/execution-spec-tests/blob/main/src/ethereum_test_forks/transition_base_fork.py file and follow the same pattern as transitions_to/transitions_from:

https://github.com/ethereum/execution-spec-tests/blob/2201c2e1c3cae5d5c2a2af12c025446845cf1069/src/ethereum_test_forks/transition_base_fork.py#L15-L23

https://github.com/ethereum/execution-spec-tests/blob/2201c2e1c3cae5d5c2a2af12c025446845cf1069/src/ethereum_test_forks/transition_base_fork.py#L97-L98

marioevz avatar May 05 '25 18:05 marioevz

Sorry for the delay—does this look correct now?

ArunRawat404 avatar May 15 '25 15:05 ArunRawat404

Stale. But let's keep issue ethereum/execution-specs#1540 open

felix314159 avatar Aug 11 '25 09:08 felix314159