execution-spec-tests icon indicating copy to clipboard operation
execution-spec-tests copied to clipboard

Different exceptions, same description

Open andreiburdusa opened this issue 1 year ago • 1 comments

I can't figure out what GAS_ALLOWANCE_EXCEEDED means. I believe its description is wrong, since it's the same as for TYPE_3_TX_MAX_BLOB_GAS_ALLOWANCE_EXCEEDED.

andreiburdusa avatar Feb 24 '25 12:02 andreiburdusa

Thats because some clients have different exceptions in the same scensrio. We shall utilize python feature of concatenating the exceptions in such cases in tests.

Example: On the same test. Client A throws MaxBlobGasAllowence Cliebt B throws Allowance exceeded

So the test has to have both exception codes expected. MaxBlobGasAllowence|AllowanceExceeded To account for different strings on different clients.

As well as making sure in the mapper that the same string does not repeat in different exception codes.

winsvega avatar Apr 21 '25 07:04 winsvega

Thanks for explaining, can be closed

felix314159 avatar Sep 01 '25 13:09 felix314159