execution-spec-tests icon indicating copy to clipboard operation
execution-spec-tests copied to clipboard

feat(consume): allow geth to validate eof test vectors via direct (#1232)

Open felix314159 opened this issue 1 year ago • 0 comments

🗒️ Description

Geth supports eofparse and can be used to validate a given eof test (code valid yes/no without running the code). The command I used for fill was uv run fill -vv -m "not slow" -m eof_test --fork=osaka --evm-bin=$HOME/Documents/evmone/build/bin/evmone-t8n and the consume command I tested the code with was uv run consume direct --input=./fixtures/eof_tests --bin=$HOME/Documents/go-ethereum/build/bin/evm -s (I added -s to see the output of some print statements I put in test_via_direct.py to see more detailed info about what is going on). It shows all 3895 tests passed in less than a minute, lmk what can be improved. Next I would try to do the same for consume direct via evmone.

🔗 Related Issues

✅ Checklist

  • [ ] All: Set appropriate labels for the changes.
  • [ ] All: Considered squashing commits to improve commit history.
  • [ ] All: Added an entry to CHANGELOG.md.
  • [ ] All: Considered updating the online docs in the ./docs/ directory.
  • [ ] Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • [ ] Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • [ ] Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • [ ] Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

felix314159 avatar Feb 24 '25 11:02 felix314159