eth-utils icon indicating copy to clipboard operation
eth-utils copied to clipboard

Expand currency test suite to fuzz test using float values.

Open pipermerriam opened this issue 7 years ago • 4 comments

What was wrong?

The test suite for to_wei is not doing fuzz testing against inputs of float type. This should be done as I'm not currently sure that there aren't odd float values that won't produce un-expected results.

How can it be fixed?

Add float inputs to the fuzz testing suite to see that from_wei(to_wei(v, 'ether'), 'ether') == decimal.Decimal(str(v)) for float inputs.

pipermerriam avatar May 09 '18 22:05 pipermerriam

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to it.

gitcoinbot avatar May 17 '18 18:05 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 months, 3 weeks ago. Please review their action plans below:

1) dilatebrave has started work.

I will do it in 1 day

Learn more on the Gitcoin Issue Details page.

gitcoinbot avatar May 17 '18 23:05 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 75.0 DAI (75.0 USD @ $1.0/DAI) has been submitted by:

  1. @dilatebrave

@gdipri01 please take a look at the submitted work:

  • PR by @dilatebrave

gitcoinbot avatar May 18 '18 03:05 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @dilatebrave.

gitcoinbot avatar Jun 13 '18 16:06 gitcoinbot