ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Add ERC: Bonding curve-embedded liquidity for NFTs

Open vgorin opened this issue 2 years ago • 7 comments

Standard for embedding liquidity into ERC-721 Non-Fungible Tokens (NFTs) without modifications to ERC-721.

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

vgorin avatar Mar 06 '24 12:03 vgorin

✅ All reviewers have approved.

eip-review-bot avatar Mar 06 '24 12:03 eip-review-bot

Hello, Andrew @abcoathup !

This looks to get stuck on @eip-review-bot review, though all the checks have passed. Is there anything I can do to unblock the merge?

Thank you!

vgorin avatar Mar 20 '24 07:03 vgorin

Hello, @gaudren , thanks for taking the time to review this again.

It looks like for the merge to happen the branch needs to be updated with the latest changes from master and in the same time be reviewed/approved, which is unlikely to happen simultaneously.

Could you please suggest how this can be unblocked? Thank you!

vgorin avatar Apr 01 '24 12:04 vgorin

@vgorin Once an editor approves (I am not an editor), the bot will merge for you.

gaudren avatar Apr 03 '24 15:04 gaudren

Hello, @abcoathup , thanks again for reviewing the EIP.

I've resolved all the review points you've raised, but probably didn't ping you directly to re-review (not sure if you receive a notification automatically). Pinging here.

Thanks.

vgorin avatar Apr 08 '24 18:04 vgorin

I'm curious, did you use ChatGPT to help write this? Isn't a problem either way.

Yes, ChatGPT was used initially to help with the overall structure of the EIP, and to help with the terminology.

vgorin avatar May 01 '24 08:05 vgorin

The commit 32775482ad77bc225f353a41ef574123d9f9f29d (as a parent of c3be0f7c417a53a7d6d1e5ee62f1d9ba7896750b) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar May 01 '24 08:05 github-actions[bot]