fastsmt icon indicating copy to clipboard operation
fastsmt copied to clipboard

Upgrade goal_runner to work with z3 version 4.8.7

Open maciej-bendkowski opened this issue 5 years ago • 2 comments

The current pull request upgrades the goal_runner to support z3 version 4.8.7. Essentially, it uses z3's new API to parse SMT files, cf. https://github.com/Z3Prover/z3/issues/2798. In addition, it proposes two lesser changes:

  • it uses the lowercase name of the fasttext library,
  • it adds #!/bin/sh to the run_test.sh script.

Please let me know if there's anything else I should be upgrading.

maciej-bendkowski avatar Sep 28 '20 12:09 maciej-bendkowski

DeepCode's analysis on #1608cf found:

  • :warning: 2 warnings :point_down:

Top issues

Description Example fixes
The result of fopen, which may return null flows to the first argument of fprintf. This could result in undefined behavior. Consider adding a check for nullness. Occurrences: :wrench: Example fixes
Missing close for tempfile.NamedTemporaryFile, add close or use a with block. Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

ghost avatar Sep 28 '20 12:09 ghost

DeepCode's analysis on #1608cf found:

  • :warning: 2 warnings :point_down:

Top issues

Description Example fixes
The result of fopen, which may return null flows to the first argument of fprintf. This could result in undefined behavior. Consider adding a check for nullness. Occurrences: :wrench: Example fixes
Missing close for tempfile.NamedTemporaryFile, add close or use a with block. Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

deepcodeappdev[bot] avatar Sep 28 '20 12:09 deepcodeappdev[bot]