SpLA-1.5: FindBLAS missing in installed SPLA*Config*.cmake

[dev-zero]

The installed CMake configs of SpLA-1.5 are missing a FindBLAS at some point. This is what we get in our Docker build environment when trying to build SIRIUS against SpLa-1.5 (upgrading from 1.4.0) and after fixing #17 by moving the modules/ directory manually:

[...]
-- Configuring done
[91mCMake Error at src/CMakeLists.txt:98 (add_library):
  Target "sirius" links to target "BLAS::blas" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?


[0m[91mCMake Error at apps/atoms/CMakeLists.txt:1 (add_executable):
  Target "atom" links to target "BLAS::blas" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?


[0m[91mCMake Error at apps/hydrogen/CMakeLists.txt:1 (add_executable):
  Target "hydrogen" links to target "BLAS::blas" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?


[0m[91mCMake Error at apps/dft_loop/CMakeLists.txt:1 (add_executable):
  Target "sirius.scf" links to target "BLAS::blas" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?


[0m[91mCMake Error at apps/utils/CMakeLists.txt:1 (add_executable):
  Target "unit_cell_tools" links to target "BLAS::blas" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


[0m-- Generating done
[91mCMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_CXXFLAGS_RELEASE
    SCALAPACK_INCLUDE_DIR


CMake Generate step failed.  Build files cannot be regenerated correctly.

[AdhocMan]

Thanks for reporting this. The issue was, that the CMake provided FindBLAS only provides the target since 3.18.0. So the target is defined if not available for building, but that workaround was missing in the static library config file. Should be fixed by b0a3b3f.