Eric Teubert

Results 87 comments of Eric Teubert

Had a quick look, there are ~2.000 lines of jQuery-style-JS. I don't think it's a realistic goal to rewrite all of this in one big swoop.

First ~200 lines file done :) Some thoughts: - https://github.com/nefe/You-Dont-Need-jQuery is very helpful - don't use `.innerHTML` for writing, it kills events on adjacent elements, use `.insertAdjacentHTML` instead - the...

> I have to say the frame work you have is quite massive and it is a bit hard for a newbie to understand the full dependency of a request...

Would be a good idea to check that this is handled correctly everywhere, I opened a dedicated issue: #1392

A callback function would be more flexible for other use cases but for my specific use case I'd be happy with an optional `redirectUrl` parameter.

I guess this is the same issue as here, where Chinese (zh) is selected as language? https://jsfiddle.net/twbfjbge/4/ Is there any workaround other than waiting for the fix?

Hacky solution / workaround: ```js if (typeof SubscribeButton == 'undefined') { document.write(unescape("%3Cscript class=\"podlove-subscribe-button\" src=\"https://publisher.dev/wp-content/plugins/podlove-publisher/lib/modules/subscribe_button/dist/javascripts/app.js\" data-json-data=\"podcastDataa209f41320cdd9\" data-language=\"de\" data-size=\"big auto\" data-format=\"cover\" data-style=\"filled\" data-color=\"#75ad91\"> %3E%3C/script%3E")); window.setTimeout(function() { iframes = document.querySelectorAll('.podlove-subscribe-button-iframe') for (i =...

This approach is already used with success in the Publisher https://github.com/podlove/podlove-publisher/blob/master/lib/modules/subscribe_button/button.php#L111

Great :) Close when it's committed.

If you have the Publisher setup to manually upload files to WordPress, there should be a button in the Media Files section: ![Screenhot Firefox Developer Edition 2023-12-26 20 19 08@2x](https://github.com/podlove/podlove-publisher/assets/235918/5efea3a4-2047-4eee-a29e-2f3a3bb1b830)...