etcd-io
add readIndex check in readyz
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
part of the work for https://github.com/etcd-io/etcd/issues/16007
cc @chaochn47 @serathius
@siyuanfoundation DCO check failed. Understood the corrupt alarm e2e test was authored by @serathius but you have to sign off this commit to pass the check.
git rebase HEAD~2 --signoff
Please merge the e2e tests before this.
@serathius Did you mean separating the e2e test to another PR for validating existing livez / readyz checks behaviors?
ReadIndex check changes and related test case could stay in the current PR, correct?
/cc @siyuanfoundation
Please merge the e2e tests before this.
@serathius Did you mean separating the e2e test to another PR for validating existing livez / readyz checks behaviors?
ReadIndex check changes and related test case could stay in the current PR, correct?
/cc @siyuanfoundation
@siyuanfoundation Existing livez readyz e2e test cases are added. Could you please rebase on top of main and resolve the comments?
@chaochn47 The problem with sharing the same loop is a slow apply loop would block readIndex request when there is a pending read, which makes it not much better than just using linearizableRead. So readIndex and linearizableRead has to be in separate loops.
@chaochn47 The problem with sharing the same loop is a slow apply loop would block readIndex request when there is a pending read, which makes it not much better than just using linearizableRead.
Makes sense.
So readIndex and linearizableRead has to be in separate loops.
It may not be necessary if requestCurrentIndex can be used for read index check while the current server side 7s timeout is too long for the check. This function is likely to be refactored if we go down this route.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@siyuanfoundation: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-etcd-verify | e998d9a6207ad2a48b35aebc6bf3ef2e9213ecaa | link | true | /test pull-etcd-verify |
| pull-etcd-unit-test-amd64 | e998d9a6207ad2a48b35aebc6bf3ef2e9213ecaa | link | true | /test pull-etcd-unit-test-amd64 |
| pull-etcd-unit-test-arm64 | e998d9a6207ad2a48b35aebc6bf3ef2e9213ecaa | link | true | /test pull-etcd-unit-test-arm64 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.