harbor icon indicating copy to clipboard operation
harbor copied to clipboard

Removed redundant a labelView hidden

Open wizages opened this issue 10 years ago • 6 comments

This could issues where that other tweaks may use this and since you don't check if your tweak is enabled this is hell of bad practice.... Defiantly since you call it after %orig;

wizages avatar Nov 03 '15 19:11 wizages

If you move an app outside of the dock and back to the home screen, the label will remain hidden without this code.

eswick avatar Nov 09 '15 17:11 eswick

Try this instead I get what you mean haha.

wizages avatar Nov 09 '15 21:11 wizages

Isn't that the same as before, though? What are you trying to accomplish?

eswick avatar Nov 09 '15 21:11 eswick

No I moved the if statement into the enable. Currently what your tweak is doing is it is preventing any other tweak from using the label hidden function because you call it after the layout is done being set up. And the worst part is you arent even checking if your tweak is enabled so no one can use this hidden function because you just automatically set it to be not hidden.

wizages avatar Nov 09 '15 21:11 wizages

But the bug would still be present when Harbor is enabled, would it not?

eswick avatar Nov 10 '15 13:11 eswick

I compiled the tweak and made sure it all works. This is a fix that will enable me to fix label notify for my next update!

wizages avatar Nov 15 '15 18:11 wizages