windmill-react-ui icon indicating copy to clipboard operation
windmill-react-ui copied to clipboard

Transition component doesn't work properly on entrance

Open muametgrooby opened this issue 5 years ago • 2 comments

  • windmill-react-ui version: 0.5.0

What you did:

I updated the windmill-ui package on windmill-dashboard-react.

What happened:

Components are not being animated on entrance.

Problem description:

It looks like modal and sidebar entrance is not animated as they should be, there's also no transition on the docs when you open the modal:

https://windmillui.com/react-ui/components/modal

Suggested solution:

Looks like downgrading back to 0.3.1 solves the issue.

muametgrooby avatar Dec 08 '20 16:12 muametgrooby

I tried to downgrade to 0.4.1 in order to use Alert, but the bug is present in that version too

Downgrading to 0.3.1 solved the problem like @muametgrooby mentioned and I created the alert component manually for the time being.

graham768 avatar Feb 10 '21 20:02 graham768

A workaround is to add a non-empty string on the appear attribute. <Transition show={isOpen} appear="_">

Not sure what's the issue could be typescript-related. But doing the above workaround allows enter transition to work. It seems

Warning: Failed prop type: Invalid prop `appear` of type `string` supplied to `Transition`, expected `boolean`.

for the CSSTransition library. I think their documentation is faulty.

Glidias avatar Apr 06 '22 08:04 Glidias