essentialenemy
text formatting issues
Hey thanks for making this template! I really like it. And it looks great in dark mode
A couple issues I've been running into:
- ability to have the home page be a static About page and the blog be on a different page
- better support for images that align-left or right and text padding around them
- difficulties differentiating between h1/h2/h3/h4/h5 text size and the text surrounding it is not even
thanks again!
Hi Allison, thank you for the kind words!
I have actually received a few emails from people wanting to set an alternative page as the home page and an update to provide this is currently in the works.
As for the other two issues that you mentioned, I will begin ironing out those issues soon and provide an update in the very near future.
Cheers, Victor
Hey Victor,
Thanks! That’s awesome!
You can see how I’ve changed it here: https://eager-montalcini-f8c6f4.netlify.com/ https://eager-montalcini-f8c6f4.netlify.com/ I’ve ironed out some of the issues but I’m by no means a designer or anything.
-- Allison Burtch LinkedIn https://www.linkedin.com/in/allisonburtch/ | Website https://allisonburtch.github.io/ | Twitter https://twitter.com/irl | Email mailto:[email protected]
On Mar 5, 2020, at 1:33 PM, Victor Johnson [email protected] wrote:
Hi Allison, thank you for the kind words!
I have actually received a few emails from people wanting to set an alternative page as the home page and an update to provide this is currently in the works.
As for the other two issues that you mentioned, I will begin ironing out those issues soon and provide an update in the very near future.
Cheers, Victor
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/essentialenemy/noir/issues/1?email_source=notifications&email_token=AAR3XOWFSQNMOGDJRHK4FN3RF7V6HA5CNFSM4LBUIMOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN6MPVQ#issuecomment-595380182, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR3XOTJBYJ27LP2YEUIW3TRF7V6HANCNFSM4LBUIMOA.
Have you forked the repo so that you can more easily merge changes that I make in the future or are you just going to do so manually as needed?
Nice use of the buttons I included 😉
Unfortunately I didn’t fork it. I downloaded the zip and then copied it over.
Allison Burtch LinkedIn https://www.linkedin.com/in/allisonburtch/ | Website https://allisonburtch.github.io/ | Twitter https://twitter.com/irl | Email mailto:[email protected]
On Mar 5, 2020, at 1:47 PM, Victor Johnson [email protected] wrote:
Have you forked the repo so that you can more easily merge changes that I make in the future or are you just going to do so manually as needed?
Nice use of the buttons I included 😉
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/essentialenemy/noir/issues/1?email_source=notifications&email_token=AAR3XOVUVERXSZMHCBCAGO3RF7XUVA5CNFSM4LBUIMOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN6OBCQ#issuecomment-595386506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR3XOXF5RYR5YPVT3JRQLLRF7XUVANCNFSM4LBUIMOA.
You did a good job of making your site a static page instead. Always welcome a pull request to improve the quality of the code.
Allison,
Could you elaborate a bit more on, "better support for images that align-left or right and text padding around them"...I would like to know if the issue is with a parent container, etc...?
Regarding, "difficulties differentiating between h1/h2/h3/h4/h5 text size and the text surrounding it is not even"...you are absolutely right about this...font sizing and margins are all over the place so I must have been drinking the night I worked on that lol. I will be bringing some consistency to those block-level elements.
Thank you kindly, Victor