esp-protocols icon indicating copy to clipboard operation
esp-protocols copied to clipboard
verified publisher icon espressif

feat(websocket): Create specific Event for PONG message

Open glmfe opened this issue 8 months ago • 2 comments

Description

  • Separate the PONG message from generic payload, this can make it easier to identify when a timeout occur when receiving a payload

Related

  • Fixes #777
  • Fixes #858

glmfe avatar Aug 26 '25 22:08 glmfe

I believe this should be marked as a breaking change. Although the event is new, how the users were dealing with the PONG message before?

euripedesrocha avatar Sep 03 '25 14:09 euripedesrocha

@euripedesrocha

I believe this should be marked as a breaking change. Although the event is new, how the users were dealing with the PONG message before?

From all the context I've got they were all being handled at the "WEBSOCKET_EVENT_DATA" or ignored, have no inputs on if they were also handled in an app level... But yes, this might be a breaking change.

glmfe avatar Sep 03 '25 15:09 glmfe