std-training icon indicating copy to clipboard operation
std-training copied to clipboard

Update esp and riscv dependencies

Open 9names opened this issue 3 years ago • 1 comments

Update a few more dependencies to get things building

9names avatar Jul 30 '22 08:07 9names

A bunch of small things need updating as the API around some functions have changed

9names avatar Jul 30 '22 12:07 9names

@9names This is marked as draft, what is missing for it to be ready for review/merge?

Mirabellensaft avatar Aug 11 '22 15:08 Mirabellensaft

I was in the middle of testing if mqtt working, and got sidetracked by other projects. it looks like I didn't push those changes so it's probably ok to mark as ready for review.

9names avatar Aug 11 '22 20:08 9names

@9names Would you mind adding those changes mentioned? Currently for me neither mqtt nor i2c-sensor-reading are building.

BriocheBerlin avatar Aug 15 '22 14:08 BriocheBerlin

But... CI is green? Are they not being built, or have dependencies moved underneath us?

I should close this PR, as it against amanjeev's branch but both have been rebased against main merging it would be problematic.

9names avatar Aug 15 '22 21:08 9names

I've pushed the WIP changes into https://github.com/9names/espressif-trainings/tree/mqtt-rebase. My recollection is that it mqtt compiles but the impl should not be considered correct (I did not get it communicating with my mqtt server)

9names avatar Aug 15 '22 22:08 9names

Closed through https://github.com/ferrous-systems/espressif-trainings/pull/99

BriocheBerlin avatar Sep 02 '22 13:09 BriocheBerlin